Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard: Add kernel to Review step (HMS-5324) #2744

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

regexowl
Copy link
Collaborator

@regexowl regexowl commented Jan 14, 2025

This adds a kernel expandable to the Review step.

JIRA: HMS-5324

@regexowl
Copy link
Collaborator Author

/jira-epic HMS-5192

@schutzbot schutzbot changed the title Wizard: Add kernel to Review step Wizard: Add kernel to Review step (HMS-5324) Jan 14, 2025
@regexowl regexowl force-pushed the kernel-on-review-step branch 5 times, most recently from d788baa to 06b14c7 Compare January 22, 2025 12:10
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.57%. Comparing base (aa80861) to head (4a78538).
Report is 2 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2744      +/-   ##
==========================================
+ Coverage   84.53%   84.57%   +0.03%     
==========================================
  Files         189      189              
  Lines       21577    21623      +46     
  Branches     2143     2150       +7     
==========================================
+ Hits        18241    18287      +46     
  Misses       3314     3314              
  Partials       22       22              
Files with missing lines Coverage Δ
...ents/CreateImageWizard/steps/Review/ReviewStep.tsx 94.88% <100.00%> (+0.27%) ⬆️
...teImageWizard/steps/Review/ReviewStepTextLists.tsx 94.94% <100.00%> (+0.21%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa80861...4a78538. Read the comment docs.

@regexowl regexowl force-pushed the kernel-on-review-step branch 3 times, most recently from 6df5781 to afd6540 Compare January 27, 2025 12:26
@regexowl regexowl marked this pull request as ready for review January 27, 2025 12:26
@regexowl
Copy link
Collaborator Author

/retest

Copy link
Collaborator

@lucasgarfield lucasgarfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

This adds a kernel expandable to the Review step.
@lucasgarfield lucasgarfield merged commit 96d6858 into osbuild:main Jan 27, 2025
14 of 15 checks passed
@regexowl regexowl deleted the kernel-on-review-step branch January 28, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants