wizard: create new component with eyeIcon button inside textInput (HMS-5289) #2727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #2727 +/- ##
==========================================
+ Coverage 84.75% 84.77% +0.01%
==========================================
Files 187 187
Lines 21270 21311 +41
Branches 2088 2093 +5
==========================================
+ Hits 18027 18066 +39
- Misses 3221 3223 +2
Partials 22 22
Continue to review full report in Codecov by Sentry.
|
|
Some inspiration for you, we should try to follow PF as closely as possible: |
mgold1234
force-pushed
the
extend_button_pass
branch
2 times, most recently
from
506aea1 to
64b640c
Compare
mgold1234
changed the title
|
/jira-epic HMS-4181 |
schutzbot
changed the title
mgold1234
changed the title
mgold1234
force-pushed
the
extend_button_pass
branch
from
64b640c to
eb4f214
Compare
mgold1234
force-pushed
the
extend_button_pass
branch
3 times, most recently
from
bcc86b9 to
038c7f2
Compare
lucasgarfield
force-pushed
the
extend_button_pass
branch
from
038c7f2 to
9179ea8
Compare
lucasgarfield
requested changes
Jan 13, 2025
src/Components/CreateImageWizard/steps/Users/component/UserInfo.tsx
Outdated
Show resolved
Hide resolved
src/Components/CreateImageWizard/steps/Users/component/UserInfo.tsx
Outdated
Show resolved
Hide resolved
src/Components/CreateImageWizard/steps/Users/component/UserInfo.tsx
Outdated
Show resolved
Hide resolved
mgold1234
force-pushed
the
extend_button_pass
branch
from
9179ea8 to
90a26c4
Compare
mgold1234
force-pushed
the
extend_button_pass
branch
9 times, most recently
from
958010e to
20172d3
Compare
regexowl
reviewed
Jan 23, 2025
| type={isPasswordVisible ? 'text' : 'password'} | ||
| ouiaId={ouiaId || ''} | ||
| data-testid={dataTestId} | ||
| aria-label={ariaLabel || ''} |
There was a problem hiding this comment.
There are duplicate aria labels in the props - aria-label and ariaLabel. isDisabled prop is missing. warning is missing also.
There was a problem hiding this comment.
I will add them as part of rest., what do you think?
mgold1234
force-pushed
the
extend_button_pass
branch
2 times, most recently
from
c33dfbb to
6d36b0a
Compare
this commit create new component with add eyeIcon button inside textInput, for password field
mgold1234
force-pushed
the
extend_button_pass
branch
from
6d36b0a to
dbde53a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit create new component with eyeIcon button inside textInput,
for password field
JIRA: HMS-5289