V2Wizard: Add descriptions to package recommendations (HMS-4187) #2114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regexowl
changed the title
regexowl
force-pushed
the
add-desc-repo-pkg-recommendations
branch
from
5b2e844 to
b898e0c
Compare
amirfefer
reviewed
Jun 5, 2024
There was a problem hiding this comment.
Thanks @regexowl 👍
I've tested it and it works as expected!
In general, the recommended packages block has a slight optimization issues, seems there is no query caching whatsoever, when the user triggers the same api call with the same packages, a full round trip is started:
Screen.Recording.2024-06-05.at.14.44.20.mov
This is not related to this PR specifically, I guess it related to the useRecommendPackageMutation effect.
Excellent, thank you! Yeah, the package recommendations are still very much a stage-preview feature for now and we should refine it along the way. |
This moves the RH repository used in "Package repository" column to an exportable const.
After the list of package recommendations is fetched, each of the packages gets queried as a searchTerm against the list of distribution repositories. This fetched the summary of the package which can be used as a description.
regexowl
force-pushed
the
add-desc-repo-pkg-recommendations
branch
from
b898e0c to
113a248
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds descriptions to the package recommendations.