Readme update #932
Merged
Readme update #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcl
previously requested changes
Dec 7, 2023
elkoniu
force-pushed
the
readme-update
branch
from
824afab to
18868d1
Compare
Thank you for the review. I was totally not aware that this |
elkoniu
force-pushed
the
readme-update
branch
from
18868d1 to
4b2e6b3
Compare
|
@elkoniu Looks like something went wrong in the force-push..? |
elkoniu
force-pushed
the
readme-update
branch
from
4b2e6b3 to
0d3c59d
Compare
Yes, my quick fix after review was so quick that I did it on the wrong local branch :) |
elkoniu
force-pushed
the
readme-update
branch
from
0d3c59d to
3e595d1
Compare
|
@bcl Code updated and rebased :) |
Thanks :) |
elkoniu
force-pushed
the
readme-update
branch
from
3e595d1 to
828f77e
Compare
|
@ondrejbudai I guess this is a merge candidate :) |
croissanne
approved these changes
Dec 18, 2023
croissanne
previously requested changes
Dec 18, 2023
croissanne
reviewed
Dec 18, 2023
elkoniu
force-pushed
the
readme-update
branch
2 times, most recently
from
fc85d03 to
d5a89cd
Compare
ochosi
dismissed stale reviews from croissanne and bcl
The concerns of this review are alleviated, the corresponding code has been removed.
Testing was part of "build" target. It has been separated as a standalone "test" target.
Comparing to osbuild and osbuild-composer repository, README file content was very limited. It has been updated to unify structure with other osbuild related repositories.
ochosi
force-pushed
the
readme-update
branch
from
d5a89cd to
96c40d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Makefile and README to be consistent with osbuild and osbuild-composer