v1: include compose_id in clone response #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
ezr-ondrej
force-pushed
the
return_compose_id
branch
from
168a0ae to
0b9d70f
Compare
ezr-ondrej
changed the title
ezr-ondrej
force-pushed
the
return_compose_id
branch
4 times, most recently
from
81d605a to
8d7e48e
Compare
ezr-ondrej
changed the title
ezr-ondrej
force-pushed
the
return_compose_id
branch
2 times, most recently
from
380a116 to
14ce777
Compare
ezr-ondrej
force-pushed
the
return_compose_id
branch
2 times, most recently
from
00e9d5a to
c76df9d
Compare
|
🍏 🎉 |
|
@ezr-ondrej ugh I didn't press the button ._. can you rebase, happy to ack again |
Clones should include their parent ID, to easily match them. It follows the rest guidelines to be traversable.
ezr-ondrej
force-pushed
the
return_compose_id
branch
from
c76df9d to
94d1de7
Compare
|
Sure :) here it goes! :) |
|
/retest |
|
🍏 🎉 |
croissanne
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clones should include their parent ID, to easily match them.
This follows rest standards.
I've got no idea how to do this properly, but I just felt it would be really nice to have compose_id in the clone detail response 🤔