v1: fix getting baseurl for content sources upload repos (HMS-5498) #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/jira-epic HMS-4930 |
schutzbot
changed the title
croissanne
force-pushed
the
fix-upload-url
branch
from
5b56fb1 to
c7c866b
Compare
lzap
requested changes
Feb 13, 2025
There was a problem hiding this comment.
I already got rid of capital letters from all errors, let's continue with that? The reason for this is they do not wrap nicely if capitals are used. E.g. user error: Something wrong: database connection failed vs user error: something wrong: connection error.
These repositories don't have the `Url` set, only the `LatestSnapshotUrl` is set.
croissanne
force-pushed
the
fix-upload-url
branch
from
c7c866b to
8ccff48
Compare
|
CI was green, https://gitlab.com/redhat/services/products/image-builder/ci/image-builder/-/commit/8ccff4805fd0bd58a45d47f2c5bf34e83cc9b8b2 needs an update due to the renaming. Will do that now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These repositories don't have the
Urlset, only theLatestSnapshotUrlis set.HMS-5469
JIRA: HMS-5498