Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/config: make feature flags optional #1460

Merged
merged 1 commit into from
Jan 17, 2025
Merged

internal/config: make feature flags optional #1460

merged 1 commit into from
Jan 17, 2025

Conversation

croissanne
Copy link
Member

The community clowdenv doesn't have feature flag support, so don't crash if it's nil.

schuellerf
schuellerf approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@schuellerf schuellerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@schuellerf
Copy link
Contributor

… although some tests are missing ;)

ezr-ondrej
ezr-ondrej approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@ezr-ondrej ezr-ondrej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@croissanne @ezr-ondrej
internal/config: make feature flags optional
b526096 
The community clowdenv doesn't have feature flag support, so don't crash
if it's nil.
@ezr-ondrej ezr-ondrej force-pushed the ib-fix-unleash-flags branch from 5602f3b to b526096 Compare January 17, 2025 14:21
@ezr-ondrej ezr-ondrej enabled auto-merge (rebase) January 17, 2025 14:21
@codecov Codecov
Copy link

codecov bot commented Jan 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/config/utils.go 0.00% 10 Missing ⚠️
Files with missing lines Coverage Δ
internal/config/utils.go 29.68% <0.00%> (-0.48%) ⬇️

@ezr-ondrej ezr-ondrej merged commit 8bdd9bc into osbuild:main Jan 17, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzap lzap lzap approved these changes

@ezr-ondrej ezr-ondrej ezr-ondrej approved these changes

@schuellerf schuellerf schuellerf approved these changes

@amirfefer amirfefer Awaiting requested review from amirfefer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@croissanne @schuellerf @lzap @ezr-ondrej