Added RSA SSH key type as default. #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. The only kind suggestion is consider using Imperative mood in commit messages ;) It comes from 50/72 length recommendation, where 50 is for the message itself and 72 is for the commit body. Verb endings like -s, -ed, or -ing eat chars which can be used differently or dropped. |
Added docstring to the function explaining the behavior. Formatted the file with auto-formatter.
narmaku
force-pushed
the
ssh-keygen-add-key-type
branch
from
0abec1e to
3bf7aab
Compare
narmaku
force-pushed
the
ssh-keygen-add-key-type
branch
from
3bf7aab to
8b7523b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added docstring to the function explaining the behavior. Formatted the file with auto-formatter.