Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIV: Refactor test_yum_group_install #333

Merged
merged 8 commits into from
Aug 8, 2024
Merged

Conversation

sshmulev
Copy link
Collaborator

@sshmulev sshmulev commented Aug 6, 2024

@sshmulev sshmulev requested a review from narmaku August 6, 2024 06:32
test_suite/cloud/test_aws.py Outdated Show resolved Hide resolved
test_suite/cloud/test_aws.py Outdated Show resolved Hide resolved
test_suite/cloud/test_aws.py Outdated Show resolved Hide resolved
test_suite/cloud/test_aws.py Outdated Show resolved Hide resolved
@narmaku
Copy link
Collaborator

narmaku commented Aug 6, 2024

@sshmulev please rebase from main and update the branch, so new runners will be used and CI tests will hopefully pass.

@sshmulev sshmulev force-pushed the refactor_test_yum_group_install branch from fa8f240 to 4cfc9d3 Compare August 6, 2024 07:43
test_suite/cloud/test_aws.py Outdated Show resolved Hide resolved
test_suite/cloud/test_aws.py Outdated Show resolved Hide resolved
test_suite/cloud/test_aws.py Show resolved Hide resolved
@narmaku
Copy link
Collaborator

narmaku commented Aug 7, 2024

@sshmulev build is failing, but because the test case is marked as "pub", so it will not be run in the Image Builder CI. We have a bug where CIV returns 1 when there were no test cases collected to run. So we can ignore this.

However, we should test in a few AMIs from a push task. Once we test that and we are sure the code behaves as expected, we can merge this.

Copy link
Collaborator

@narmaku narmaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small comment.

test_suite/cloud/test_aws.py Outdated Show resolved Hide resolved
test_suite/cloud/test_aws.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@narmaku narmaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test_suite/cloud/test_aws.py Show resolved Hide resolved
@narmaku
Copy link
Collaborator

narmaku commented Aug 8, 2024

image
Output of successful scenario looks like expected! Merging.

@narmaku narmaku merged commit 8b66d20 into main Aug 8, 2024
2 of 3 checks passed
@narmaku narmaku deleted the refactor_test_yum_group_install branch August 8, 2024 07:25
dev_tools_install_command = 'yum -y groupinstall "Development tools"'
result = host.run(dev_tools_install_command)

if result.failed:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC it should fail just for BYOS due to missing subscription.
But it should work with PAYG due to rhui respositories.

@narmaku Shall we immediately fail for PAYG?

Or do I miss some context :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants