-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIV: Refactor test_yum_group_install #333
Conversation
@sshmulev please rebase from main and update the branch, so new runners will be used and CI tests will hopefully pass. |
fa8f240
to
4cfc9d3
Compare
@sshmulev build is failing, but because the test case is marked as "pub", so it will not be run in the Image Builder CI. We have a bug where CIV returns 1 when there were no test cases collected to run. So we can ignore this. However, we should test in a few AMIs from a push task. Once we test that and we are sure the code behaves as expected, we can merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a small comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dev_tools_install_command = 'yum -y groupinstall "Development tools"' | ||
result = host.run(dev_tools_install_command) | ||
|
||
if result.failed: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC it should fail just for BYOS due to missing subscription.
But it should work with PAYG due to rhui respositories.
@narmaku Shall we immediately fail for PAYG?
Or do I miss some context :-)
https://issues.redhat.com/browse/CLOUDX-837