Added awscli2 package test suite. #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narmaku
force-pushed
the
add-awscli2-test-suite
branch
5 times, most recently
from
36fdd7c to
6943dfd
Compare
narmaku
commented
Jun 21, 2024
|
Code looks great to me! I had a good think about other worthwhile test cases to include, but to the best of my knowledge, I think the current tests are enough to ensure the package is working properly :) |
Related task: CLOUDX-927
narmaku
force-pushed
the
add-awscli2-test-suite
branch
from
fd4e089 to
a0e762e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related task: CLOUDX-927