CIV: Add new test for otel package #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshmulev
force-pushed
the
new_otel_package
branch
4 times, most recently
from
bafdf48 to
af45b1c
Compare
sshmulev
force-pushed
the
new_otel_package
branch
5 times, most recently
from
64ad9cc to
ebe1a19
Compare
narmaku
reviewed
May 8, 2024
narmaku
requested changes
May 8, 2024
|
Added the changes will push them |
sshmulev
force-pushed
the
new_otel_package
branch
6 times, most recently
from
e7a6cf9 to
9bb2167
Compare
narmaku
requested changes
May 9, 2024
sshmulev
force-pushed
the
new_otel_package
branch
from
37d2097 to
f38ccab
Compare
|
@sshmulev did the tests passed in your local environment? If so, let's merge this! 🚀 |
narmaku
approved these changes
Jul 4, 2024
narmaku
approved these changes
Jul 8, 2024
sshmulev
force-pushed
the
new_otel_package
branch
2 times, most recently
from
faffbc6 to
d4fd16a
Compare
narmaku
requested changes
Jul 12, 2024
narmaku
reviewed
Jul 17, 2024
|
@sshmulev Please resolve the old/outdated conversations, otherwise they flood the pull request history and it's harder to follow-up. Also I won't get notified about resolutions and my latest code review status won't change, which will be even more confusing. Thanks. |
narmaku
approved these changes
Jul 18, 2024
Resolved Logger - removed it Changed fixture scope to "session" instead of "function"
…nsole_lib.print_divider
According to these demands: https://gist.github.com/frzifus/cc20b772dcfc6da0550ada1e7b99ccc5
fixtures.py - There are many fixtures related to this test, In my opinion it is better arranged so in this case. This fixture file is under otel_packge folder which are fixtures that are spesific only for this testing pakckage. helpers.py - The helpers file include a method that might be used for many other tests and not be limited by a fixture scope. This file may include some other generic helpful methods in our tests.
narmaku
force-pushed
the
new_otel_package
branch
from
b8ba256 to
1c6c5a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.