Deprecate --local flag (HMS-3792)
#423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
reviewed
May 7, 2024
|
Arghhh of course this breaks |
kingsleyzissou
force-pushed
the
deprecate-local
branch
2 times, most recently
from
996a9ff to
0f0f46f
Compare
achilleas-k
previously approved these changes
May 7, 2024
achilleas-k
reviewed
May 7, 2024
kingsleyzissou
force-pushed
the
deprecate-local
branch
from
0f0f46f to
53956d3
Compare
kingsleyzissou
force-pushed
the
deprecate-local
branch
from
53956d3 to
4356c1e
Compare
|
|
mvo5
previously approved these changes
May 8, 2024
kingsleyzissou
force-pushed
the
deprecate-local
branch
from
4356c1e to
bc9b951
Compare
mvo5
previously approved these changes
May 8, 2024
kingsleyzissou
force-pushed
the
deprecate-local
branch
from
bc9b951 to
cb769a3
Compare
|
Okay it's finally green now. Removing the flag also broke the cross-arch integration tests :/ |
mvo5
reviewed
May 13, 2024
ondrejbudai
requested changes
May 15, 2024
There was a problem hiding this comment.
I love this! :)
Marking this as request changes, because I want to first talk to the podman desktop folks if this is alright for them, and I want to figure out if we can somehow have bib releases, so users know what version they run, and thus which flags are supported and what's the default behaviour (git SHAs aren't very friendly in this case unfortunately).
kingsleyzissou
force-pushed
the
deprecate-local
branch
3 times, most recently
from
acc9c79 to
e3d37c7
Compare
achilleas-k
force-pushed
the
deprecate-local
branch
from
cb3dcca to
9c6b865
Compare
mvo5
previously approved these changes
Jan 15, 2025
achilleas-k
previously approved these changes
Jan 15, 2025
mvo5
force-pushed
the
deprecate-local
branch
2 times, most recently
from
4063981 to
e3492b6
Compare
achilleas-k
previously approved these changes
Jan 17, 2025
Pulling container images before building would break in the case of authenticated images on podman machine, since the auth file lives on the host and not podman machine and won't know about it. This commit deprecates the `--local` flag and warns users when it is passed to the CLI so that this won't break things for anyone who might already be using the flag. This change means that the user will have to ensure that the container is pulled to the local container store before initiating the build. Co-authored-by: Ondřej Budai <[email protected]>
Ensure that the containers have been copied into local storage for all test cases. We need to explicitly pull the container into local containers storage with the correct arch otherwise cross-arch building fails. The helper function uses the host-arch as a fallback when no target arch is provided.
Since all containers are coming from local storage and require the user to pull in the container before-hand, we can disable the `--tls-verify` flag. The containers will not be resolved from a remote registry but rather from the local container store.
This commit ensures all tests pull the container into local storage before.
kingsleyzissou
force-pushed
the
deprecate-local
branch
from
e3492b6 to
9141819
Compare
|
One or two more of the tests needed to pull the containers first, I updated Ondrej's commit with it. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
achilleas-k
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling container images before building would break in the case of authenticated images on podman machine, since the auth file lives on the host and podman machine and won't know about it.
This commit deprecates the
--localflag and puts the requirement on the user to ensure that the container is in local storage before initiating the build.