Avoid die in check_takeover for uninitialized variables #18330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
mpagot
force-pushed
the
sles4sap_get_hana_topology
branch
from
0e292c1 to
7b36f97
Compare
mpagot
requested review from
alvarocarvajald,
BillAnastasiadis,
a-kpappas,
lilyeyes and
lpalovsky
mpagot
force-pushed
the
sles4sap_get_hana_topology
branch
from
7b36f97 to
1173807
Compare
|
But in the VRs the |
Avoid an exception if get_hana_topology return an empty result. It could happens if SAPHanaSR-showAttr is not succesful and output is not parsable. This new behavior is obtained avoiding the usage of local variables in check_takeover. Sleep 30 moved in a different position only to be used once for each get_hana_topology and not to be called when there's no more retry to run. Add some unit testing for these two functions.
mpagot
force-pushed
the
sles4sap_get_hana_topology
branch
from
1173807 to
18da85a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid an exception if get_hana_topology return an empty result. It could happens if SAPHanaSR-showAttr is not successful and output is not what expected.
This new behavior is obtained avoiding the usage of local variables in check_takeover.
Sleep 30 moved in a different position only to be used once for each get_hana_topology and not to be called when there's no more retry to run.
Add some unit testing for these two functions.
Verification run:
sle-15-SP4-HanaSr-Azure-Byos-x86_64-Build15-SP4_2023-12-15T05:03:11Z-hanasr_azure_test_sapconf_spn@64bit
check_takeoverruns fine http://openqaworker15.qa.suse.cz/tests/273037#step/Crash_site_a-primary/96 but here http://openqaworker15.qa.suse.cz/tests/273037#step/Crash_site_b-primary/99 it is not okIt is because field
sync_stateis missing in SAPHanaSR-showAttr --format=scriptIt needs PR improvement: https://github.com/os-autoinst/os-autoinst-distri-opensuse/compare/117380726ba2dd7f10aa6c2a3078a08886185ed7..18da85a3f6ba7f6965c97064170154e325960242
sle-12-SP5-Azure-SAP-PAYG-Incidents-x86_64-Build:31892:nfs-utils-SAPHanaSR-ScaleUp-PerfOpt@az_Standard_E8s_v3
sudo zypper --no-gpg-checks ar -f -n TEST_0due to locked zypper. Issue is not related to the PR content, but prevent code of interest to be reached.Test died: Test failed: takeover failed to completein case ofSignon CIB failed. It is the right way to react to terminate an unsuccessful takeover