feat: allow user to scale more precisely with ContainerResource in hpa #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noony
commented
Dec 17, 2024
| @@ -20,17 +21,34 @@ spec: | |||
| maxReplicas: {{ .Values.deployment.autoscaling.maxReplicas }} | |||
| metrics: | |||
| {{- with .Values.deployment.autoscaling.targetMemory }} | |||
| {{- if and (and (not (empty $kubeVersion)) (semverCompare ">=1.30-0" $kubeVersion) (not (empty $.Values.deployment.autoscaling.extraMetrics))) }} | |||
There was a problem hiding this comment.
to avoid breaking change for people already using extraContainers, we switch to containerResource only when it's available in kubernetes > 1.30 and Values.deployment.autoscaling.extraMetrics is defined.
noony
changed the title
noony
changed the title
noony
changed the title
Demonsthere
reviewed
Jan 7, 2025
There was a problem hiding this comment.
I like the idea, but not 100% sold on the implementation 🤔
I was wondering if we should not proceed on a cleaner path:
- define a new template for hpa, that is for k8s 1.30+ where we use only ContainerResources, as from my pov we should scale on the base of the core ory apps, and not sidecars
- then at 1.3x deprecate the older file and leave only ContainerResource scaling
- also, regardless of which path we choose, i would prefer to have it across all charts, and not only oathkeeper ;)
wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue or Design Document
Add possibility to define extra containers metrics in hpa to scale independently and more precisely when multiple containers are declared.
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
Further comments