Translated into C# 10, added CMake support, a build script and various fixes. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added “ORLP_” prefix to declspec macro (to prevent possible collisions with other libraries making use of the same name). * Added CMakeLists.txt and build.sh for easy packaging and inclusion into other projects. * Deleted .dll files inside repo.
…nd this idea; CMake packs the ed25519.h in shared builds into the nice output include dir just fine on its own). Modified CHANGELOG accordingly. Copy license.txt into CMake build output dir on package. Added "ORLP_" prefix to ed25519.h header guard macro to prevent potential name clashes.
…s (this dir needs to be copied to consuming C# project output directories, where the executable resides).
Updated csharp/lib/x64/windows/orlp-ed25519.dll
… for better libsodium/SUPERCOP ref10 interop support.
- Added build and test shell scripts (both for Windows and Linux/Mac) - Added feature flag to CMakeLists.txt for preventing potentially unnecessary NULL-checks - Reformatted src code files (using a .clang-format file; also added in this commit) - Simplified verify function a bit
…s a NuGet package to nuget.org
GlitchedPolygons
changed the title
…include XML code docs.
…naged C# KeyExchangeRef10 impl. instead of just the Clear method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there :)
Cool stuff! Thought I'd fork this and add a
CMakeLists.txtalong with abuild.shto make including, building, linking and packaging the library easy. Thebuild.shbash script also works under Windows if run using Git Bash for Windows (bash build.sh). It requires CMake to be installed on the system.I also implemented a C# wrapper class, which can be found inside the
csharp/folder and is as easy as copy-pasting it into a consuming C# project. If you like it, merge it, otherwise just ditch it: fully understandable!I'll keep my own fork anyway.
For more details, check out the
CHANGELOG.Cheers, all the best! :D
[EDIT]
csharp/folder to access both the managed C# variant (fully translated from ANSI C into C# 10) as well as the native code C# wrapper (which calls the native binary DLL/shared lib).