add to signOrder secretHash only if targetChainId exist

orionprotocol · Jan 19, 2024 · 330fc51 · 330fc51
1 parent 72e1e94
commit 330fc51
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 7 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@orionprotocol/sdk",
-  "version": "0.20.42-rc4",
+  "version": "0.20.42-rc5",
   "description": "Orion Protocol SDK",
   "main": "./lib/index.cjs",
   "module": "./lib/index.js",

diff --git a/src/crypt/signOrder.ts b/src/crypt/signOrder.ts
@@ -55,8 +55,12 @@ export const signOrder = async (
     )),
     nonce,
     expiration,
-    secretHash,
-    targetChainId,
+    ...(targetChainId !== undefined
+      ? {
+        secretHash,
+        targetChainId
+      }
+      : {}),
     buySide: side === 'BUY' ? 1 : 0,
   };
 

diff --git a/src/types.ts b/src/types.ts
@@ -49,9 +49,9 @@ export type Order = {
   matcherFee: number // uint64
   nonce: number // uint64
   expiration: number // uint64
-  secretHash: string // uint64
   buySide: 0 | 1 // uint8, 1=buy, 0=sell
-  targetChainId: ethers.BigNumberish | undefined // uint64
+  secretHash?: string // uint64
+  targetChainId?: ethers.BigNumberish // uint64
 }
 
 export type LockOrder = {