Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended HasValidGettersAndSettersExcludingMatcher by exclusion of asymmetric method accessors #129

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

hsynkrtl
Copy link

@hsynkrtl hsynkrtl commented Aug 24, 2022

This PR extends the exclusion capabilities of HasValidGettersAndSettersExcludingMatcher. The new flag excludeAsynmmetricAccessors excludes properties if one of the accessor is missing and circumvents AccessorMissingException.

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #129 (ffec60f) into main (a7a2b69) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
+ Coverage   96.88%   96.96%   +0.08%     
==========================================
  Files          38       38              
  Lines         481      495      +14     
  Branches       44       47       +3     
==========================================
+ Hits          466      480      +14     
  Misses         14       14              
  Partials        1        1              
Impacted Files Coverage Δ
...a/com/google/code/beanmatchers/BeanOperations.java 77.27% <100.00%> (+2.27%) ⬆️
...ers/HasValidGettersAndSettersExcludingMatcher.java 100.00% <100.00%> (ø)
...in/java/com/google/code/beanmatchers/JavaBean.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@orien
Copy link
Owner

orien commented Sep 1, 2022

@hsynkrtl Thanks for the pull request. Do you mind updating the PR description? I'd love to understand the problem this change seeks to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants