Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(servicequotas): add dynamodb quotas #63

Merged
merged 22 commits into from
Jan 22, 2022

Conversation

OlafConijn
Copy link
Member

Issue #, if available:

Description of changes:

@codecov
Copy link

codecov bot commented Jan 18, 2021

Codecov Report

Merging #63 (d5e09e4) into master (2f48cee) will decrease coverage by 0.38%.
The diff coverage is 65.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   85.36%   84.97%   -0.39%     
==========================================
  Files          16       17       +1     
  Lines        2500     2549      +49     
  Branches      386      391       +5     
==========================================
+ Hits         2134     2166      +32     
- Misses        366      383      +17     
Flag Coverage Δ
unittests 84.97% <65.30%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
service-quotas/dynamodb/src/handlers.ts 65.30% <65.30%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f48cee...d5e09e4. Read the comment docs.

@eduardomourar
Copy link
Member

we need to change line 32 in the cicd.yml file to: pip install --upgrade pip aws-sam-cli git+https://github.com/eduardomourar/cloudformation-cli-nodejs-plugin.git otherwise the pipeline just hangs forever

@OlafConijn
Copy link
Member Author

we need to change line 32 in the cicd.yml file to: pip install --upgrade pip aws-sam-cli git+https://github.com/eduardomourar/cloudformation-cli-nodejs-plugin.git otherwise the pipeline just hangs forever

i think its still hanging? fix later?

@eduardomourar
Copy link
Member

Yes, because I need to dig deeper into the problem

@PatMyron
Copy link
Contributor

PatMyron commented Aug 27, 2021

Issues might be because SAM pins exact requirements and insists it shouldn't be installed with pip:
aws/aws-sam-cli#1424
aws-cloudformation/cloudformation-cli#579 (comment)


Also still think we should generalize quotas types: #71 (comment)

@eduardomourar eduardomourar changed the title Feat/service quotas dynamodb feat(servicequotas): add dynamodb quotas Jan 22, 2022
@eduardomourar eduardomourar merged commit e97d5c8 into master Jan 22, 2022
@eduardomourar eduardomourar deleted the feat/service-quotas-dynamodb branch January 22, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants