-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(servicequotas): add dynamodb quotas #63
Conversation
…on/aws-resource-providers into feat/service-quotas-dynamodb
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
- Coverage 85.36% 84.97% -0.39%
==========================================
Files 16 17 +1
Lines 2500 2549 +49
Branches 386 391 +5
==========================================
+ Hits 2134 2166 +32
- Misses 366 383 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
we need to change line 32 in the cicd.yml file to: |
i think its still hanging? fix later? |
Yes, because I need to dig deeper into the problem |
Issues might be because SAM pins exact requirements and insists it shouldn't be installed with pip: Also still think we should generalize quotas types: #71 (comment) |
Issue #, if available:
Description of changes: