Finished redesigning Issue 5 Exhibit #115
Conversation
Added Typography and border radius of two images.
✅ Deploy Preview for orcahome ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
package.json
Outdated
| @@ -22,17 +22,17 @@ | |||
| "@emotion/styled": "^11.6.0", | |||
| "@mui/icons-material": "^5.3.1", | |||
| "@mui/material": "^5.3.1", | |||
| "next": "^12.0.9", | |||
| "react": "17.0.2", | |||
| "next": "^13.3.0", | |||
There was a problem hiding this comment.
would be beneficial to stay with original versions of Next, React, etc.. would recommend omitting this file unless there's a feature that is not currently implemented in the previous versions
There was a problem hiding this comment.
Oh okay, I will try omitting the file. I think the versions got updated after running yarn or npm.
Trying to see if it would work.
Omitted package.json
I updated the versions manually in my local package.json based on orcahome main branch's package.json file. Ran npm install and npm ci to double check npm error messages on my local computer. Came to error messages of npm audit severity on vulnerabilities. I'm committing my changes before I try npm audit fix.
I didn't need to run npm audit fix. Pull request checks/jobs fixed after running npm prettier. https://stackoverflow.com/questions/69797806/code-style-issues-found-in-the-above-files-forgot-to-run-prettier
Removed lock.json to fix netlify build
Had to change Omit 'onTouchStart' as well. Then I ran npm run build to check if build runs through.
|
Okay, finally. All the rules are passed and CI checks are good. I think it is ready to review and merge with the main repo. |
|
Please see images below. The Exhibit section needs to be fixed- the exhibit cards need to be closer to the title "Exhibit". Please set the spacing closer- let me know if you have any questions. Also, please change name to "Exhibits".
|
|
See image- space between "Exhibits" title and card should be 80 pixels.
|
| !.vscode/*.shared*package.json |
There was a problem hiding this comment.
This doesn't seem correct. I would not expect there to be a .sharedpackage.json file as well it removes the .shared folder
what were you intending to do with this edit?
There was a problem hiding this comment.
This seems best to not add to the repo
|
|
||
| // Add support for the sx prop for consistency with the other branches. | ||
|
|
There was a problem hiding this comment.
remove, seems unnecessary spacing.
| text-align: left; | ||
| justify-content: left; | ||
| width: 100%; | ||
| /* flex-wrap: wrap; */ |
| border-radius: 10%; | ||
| } | ||
| .org :nth-of-type(2) { | ||
| /* border: solid 1px; */ |
Added Typography and border-radius of two images.
Changed Learn-style.css and Learn-style.jsx