Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(maestro): add redundancy to create deployment when receives acti… #2739

Merged

Conversation

lpegoraro
Copy link
Contributor

…vity without deployment in the database.

@lpegoraro lpegoraro requested a review from etaques October 9, 2023 21:20
@lpegoraro lpegoraro self-assigned this Oct 9, 2023
@github-actions github-actions bot added the golang label Oct 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2023

Codecov Report

Merging #2739 (9ae1056) into develop (5d512a1) will increase coverage by 1.91%.
The diff coverage is 4.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop    #2739      +/-   ##
===========================================
+ Coverage    51.25%   53.16%   +1.91%     
===========================================
  Files           79       27      -52     
  Lines         5941     1975    -3966     
===========================================
- Hits          3045     1050    -1995     
+ Misses        2896      925    -1971     
Files Coverage Δ
maestro/deployment/repository.go 38.75% <100.00%> (+1.25%) ⬆️
maestro/service/deploy_service.go 0.00% <0.00%> (ø)

... and 52 files with indirect coverage changes

Copy link
Contributor

@etaques etaques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lpegoraro lpegoraro merged commit b448764 into orb-community:develop Oct 10, 2023
20 checks passed
@lpegoraro lpegoraro deleted the feat/add_redundancy_to_activity branch January 17, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants