Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement auto refund #40

Merged
merged 38 commits into from
Feb 14, 2025
Merged

feat: implement auto refund #40

merged 38 commits into from
Feb 14, 2025

Conversation

GNaD13
Copy link
Collaborator

@GNaD13 GNaD13 commented Feb 10, 2025

No description provided.

ledanghuy1811 and others added 30 commits January 22, 2025 15:34
feat: change type sudo msg to enum
feat: tmp add ClockEndBlock for execute msg
@@ -170,6 +174,9 @@ pub fn execute(
ExecuteMsg::WithdrawAsset { coin, receiver } => {
execute_withdraw_asset(deps, info, coin, receiver)
}
// TODO: this msg for test only
// need to remove after testing is done
ExecuteMsg::ClockEndBlock { hash } => handle_clock_end_block_sudo(deps, hash),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anh check lại cái này nha, có cần remove không ạ

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chỗ này thì anh có trao đổi với Đức rùi, ý kiến của Đức là mình refund thẳng thông qua contract state, nên tx này không ảnh hưởng gì, user gọi vào cũng không sao. Hiện tại mình sẽ để tx như vậy để chủ động refund. Chắc là anh sẽ remove TODO.

Copy link
Member

@trung2891 trung2891 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@trung2891 trung2891 merged commit ff1032d into master Feb 14, 2025
2 of 4 checks passed
@trung2891 trung2891 deleted the huy/implement-refund branch February 14, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants