Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix namespace deletion on helm upgrade #68

Merged
merged 1 commit into from
May 23, 2024
Merged

Fix namespace deletion on helm upgrade #68

merged 1 commit into from
May 23, 2024

Conversation

piyush-tiwari
Copy link
Member

  • Currently helm upgrade deletes the NIC namespace if it was created by a helm install. Bug introduced in only create namespace if it doesn't exist. #55
  • If the required namespace already exists and is managed by helm, we include it in the desired manifest in deployment.yaml to preserve it during helm upgrade

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 22, 2024
nirpai
nirpai previously approved these changes May 23, 2024
View reviewed changes
@coveralls
Copy link

coveralls commented May 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9207852122

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.427%
Totals Coverage Status
Change from base Build 9207739893: 0.0%
Covered Lines: 2269
Relevant Lines: 3468
💛 - Coveralls

@nirpai nirpai force-pushed the bugfix-deploy-ns branch from 33a3a5b to 82693af Compare May 23, 2024 12:20
@nirpai nirpai merged commit cd89ac5 into oracle:main May 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirpai nirpai nirpai approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piyush-tiwari @coveralls @nirpai