Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GR-59443] Bump to new Barista version with Startup phase iterations #10607

Merged
merged 1 commit into from
Feb 13, 2025
+4 −1
Merged

[GR-59443] Bump to new Barista version with Startup phase iterations #10607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/ci/ci_common/benchmark-suites.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@

barista_template(suite_version=null, suite_name="barista", max_jdk_version=null, cmd_app_prefix=["hwloc-bind --cpubind node:0.core:0-3.pu:0 --membind node:0"], non_prefix_barista_args=[]):: cc.compiler_benchmark + {
suite:: suite_name,
local barista_version = "v0.3.0",
local barista_version = "v0.3.3",
local suite_version_args = if suite_version != null then ["--bench-suite-version=" + suite_version] else [],
local prefix_barista_arg = if std.length(cmd_app_prefix) > 0 then [std.format("--cmd-app-prefix=%s", std.join(" ", cmd_app_prefix))] else [],
local all_barista_args = prefix_barista_arg + non_prefix_barista_args,
Expand Down
3 changes: 3 additions & 0 deletions substratevm/mx.substratevm/mx_substratevm_benchmark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,7 @@ def _short_load_testing_phases(self):
Useful for the `agent` and `instrument-run` stages.
"""
return [
"--startup-iteration-count", "1",
"--warmup-iteration-count", "1",
"--warmup-duration", "5",
"--throughput-iteration-count", "0",
Expand Down Expand Up @@ -465,6 +466,8 @@ def produceHarnessCommand(self, cmd, suite):
if stage == mx_sdk_benchmark.Stage.INSTRUMENT_RUN:
# Make instrument run short
ni_barista_cmd += self._short_load_testing_phases()
if suite.context.benchmark == "play-scala-hello-world":
self._updateCommandOption(ni_barista_cmd, "--vm-options", "-v", "-Dpidfile.path=/dev/null")
# Add explicit instrument stage args
ni_barista_cmd += mx_sdk_benchmark.parse_prefixed_args("-Dnative-image.benchmark.extra-profile-run-arg=", suite.context.bmSuiteArgs) or mx_sdk_benchmark.parse_prefixed_args("-Dnative-image.benchmark.extra-run-arg=", suite.context.bmSuiteArgs)
else:
Expand Down
Loading