Use offsets from .bgv file to select appropriate text
#10510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
JaroslavTulach
commented
Jan 18, 2025
|
|
||
| private Line findLine(EditorCookie cake, int line) { | ||
| try { | ||
| return cake.getLineSet().getOriginal(line - 1); |
There was a problem hiding this comment.
Possibly IGV should honor https://www.graalvm.org/graphio/javadoc/jdk/graal/compiler/graphio/GraphLocations.html#locationOffsetStart(java.lang.Object) when the line isn't positive.
JaroslavTulach
commented
Jan 20, 2025
| @@ -63,24 +67,48 @@ private void openOrView(boolean focus) { | |||
| return; | |||
| } | |||
| int line = location.getLine(); | |||
| int[] offsets = location.getOffsetsOrNull(); | |||
There was a problem hiding this comment.
Text based languages (like Truffle ones) are likely to fill offsets rather than line numbers. Passing the offsets to the LocationOpener in faba84a and using the offsets rather than line when present. More an experiment for your consideration than bullet proof code right now.
JaroslavTulach
changed the title
.bgv file.bgv file to select appropriate text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enso is trying to generate IGV graph for our internal
IR:We had issues to provide proper
nodeSourceLocationinformation. I had to debug visualizer code to find out what's wrong. While doing that I made few fixes.-1as line location - IGV was then doing nothing - with 75d41ee it at least opens the fileNullPointerExceptions so I am adding checks andassertto catch that earlierWith these changes IGV picks up
startandendoffset fromlocationproperty and is capable to select appropriate source range. CCing @tkrodriguez, @sdedic, @Akirathan