Merge pull request #14 from cerner/height_calc_fix

Change height calculation method to max
oracle-samples · Mar 2, 2018 · ef01ea4 · ef01ea4
2 parents b5df941 + d8a3c9b
commit ef01ea4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 Next Release
 -------------
+1.3.2
+------
+* Updated default height calculation to max to account for dropdowns.
+
+
 1.3.1
 ------
 * Updated node version to 8.9.2 to support NPM 2FA

diff --git a/src/lib/dimension.js b/src/lib/dimension.js
@@ -49,7 +49,7 @@ const getWidth = {
   min: () => Math.min(...getAllMeasures(getWidth)),
 };
 
-export function calculateHeight(calMethod = 'bodyOffset') {
+export function calculateHeight(calMethod = 'max') {
   if (!(calMethod in getHeight)) {
     logger.error(`'${calMethod}' is not a valid method name!`);
   }