Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RBAC and Federation modules #5

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

RBAC and Federation modules #5

wants to merge 6 commits into from

Conversation

juliocombativo
Copy link

  • RBAC module to create groups at Google Cloud.
  • Federation module to configure Google Cloud as an identity provider.
  • Federation module to configure Identity Provider details on OCI.
  • Federation module to recreate default policies or create custom policies for modified policy scenarios.

@oracle-contributor-agreement Oracle Contributor Agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Jul 26, 2024
chanstev
chanstev reviewed Jul 30, 2024
View reviewed changes
modules/oci-identity-policies/main.tf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we leverage CIS LZ IAM modules instead of having a separate one? Is there any reason for that?

chanstev
chanstev reviewed Jul 30, 2024
View reviewed changes
modules/oci-identity-policies/oci-identity-domain/main.tf
Copy link
Member

@chanstev chanstev Jul 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any reason that we cannot leverage the CIS LZ IAM module. I've created a clone with an example in folder oci-cis-lz-iam for meanwhile, before they can support TF v1.3+.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CIS is now being used for policy creation, a note was added related to the migration to the official module code once TF 1.3+ is supported.

@juliocombativo
KT
b033e18 
* Use CIS for policy creation.
* Add service account token support.
* RBAC default group includes role information.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanstev chanstev chanstev left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliocombativo @chanstev