Fix deployment path inference #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not attempt to compute the deployment name when it is created as the `name` is optional and if not provided, will be extracted after downloading the artifact to deploy. Fixes #55
When the artifact archive is created with `tar zcf filename.tgz .`, all files path start with `./` but we do not want the application module to believe that all files are under a `.` directory that can be used as the deployment name. Strip this `./` component to fix detection of a common root directory.
smortex
changed the title
neomilium
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deployment name is optional, but the way the deployment path was computed made it mandatory to provide it.
This revert the initial behavior where the deployment name is found by inspecting the content of the artifact to deploy when all files contained in this artifact are located in a single root directory.