Skip to content

Commit

Permalink
Merge pull request #25 from Cairry/master
Browse files Browse the repository at this point in the history
[fix]: delete rule tmpl failed, update rule error
  • Loading branch information
Cairry authored Apr 23, 2024
2 parents 61876f4 + 550a8e1 commit 0bdea62
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 12 deletions.
11 changes: 6 additions & 5 deletions controllers/api/rule_template.go
Original file line number Diff line number Diff line change
Expand Up @@ -126,11 +126,12 @@ func (rtc RuleTmplController) Create(ctx *gin.Context) {

func (rtc RuleTmplController) Delete(ctx *gin.Context) {

ruleName := ctx.Query("ruleName")
err := repo.DBCli.Delete(repo.Delete{
Table: &models.RuleTemplate{},
Where: []interface{}{"rule_name = ?", ruleName},
})
var r models.RuleTemplate
_ = ctx.ShouldBindJSON(&r)

db := globals.DBCli.Model(&models.RuleTemplate{})
db.Where("rule_group_name = ? AND rule_name = ?", r.RuleGroupName, r.RuleName)
err := db.Delete(models.RuleTemplate{}).Error
if err != nil {
response.Fail(ctx, err.Error(), "failed")
return
Expand Down
10 changes: 3 additions & 7 deletions controllers/services/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,18 +88,14 @@ func (rs *RuleService) Update(rule models.AlertRule) error {
}

// 更新数据
data := repo.Updates{
Table: models.AlertRule{},
Where: []interface{}{"tenant_id = ? AND rule_id = ?", rule.TenantId, newRule.RuleId},
Updates: &newRule,
}
err := repo.DBCli.Updates(data)
db := globals.DBCli.Model(&models.AlertRule{})
db.Where("tenant_id = ? AND rule_id = ?", rule.TenantId, rule.RuleId)
err := db.Updates(newRule).Error
if err != nil {
return err
}

return nil

}

func (rs *RuleService) Delete(tid, id string) error {
Expand Down

0 comments on commit 0bdea62

Please sign in to comment.