Notification and user methods version 2 #16
Conversation
userv2/user_contact.go
Outdated
| type UserContact struct { | ||
| ID string `json:"id"` | ||
| To string `json:"to"` | ||
| ContactMethod string `json:"contactMethod"` |
There was a problem hiding this comment.
given this value is from a set of fixed values - are there plans to make this a Constant/Enum?
There was a problem hiding this comment.
I defined these fixed methods in the file:
notificationv2/constants.go
There was a problem hiding this comment.
Awesome. I was more meaning to use the Constants as the Type of the ContactMethod field in the Struct, in place of String?
There was a problem hiding this comment.
It looks great. Ok, I will change it soon.
There was a problem hiding this comment.
Great, thanks @vlamug :)
vlamug
force-pushed
the
notification_and_user_v2
branch
from
ec49053 to
6e3a273
Compare
|
@tombuildsstuff hello, I added necessary constants. Please, check it. Thanks. |
|
Hi @vlamug , thanks for your contribution. I'll be looking into your pull request, sorry for the delay. I spotted some minor errors/missing elements and will inform you when I have time to do an in depth review. |
|
@mustafanacar hello, how about making code-review? thanks. |
No description provided.