code review: improve error message

Signed-off-by: Boris Glimcher <[email protected]>
opiproject · Apr 12, 2023 · e04eca8 · e04eca8
1 parent d2789cf
commit e04eca8
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/pkg/backend/aio_test.go b/pkg/backend/aio_test.go
@@ -386,7 +386,7 @@ func TestBackEnd_ListAioControllers(t *testing.T) {
 				}
 				// Empty NextPageToken indicates end of results list
 				if tt.size != 1 && response.NextPageToken != "" {
-					t.Error("response: expected", tt, "received", response)
+					t.Error("Expected end of results, receieved non-empty next page token", response.NextPageToken)
 				}
 			}
 

diff --git a/pkg/backend/null_test.go b/pkg/backend/null_test.go
@@ -390,7 +390,7 @@ func TestBackEnd_ListNullDebugs(t *testing.T) {
 				}
 				// Empty NextPageToken indicates end of results list
 				if tt.size != 1 && response.NextPageToken != "" {
-					t.Error("response: expected", tt, "received", response)
+					t.Error("Expected end of results, receieved non-empty next page token", response.NextPageToken)
 				}
 			}
 

diff --git a/pkg/backend/nvme_test.go b/pkg/backend/nvme_test.go
@@ -339,7 +339,7 @@ func TestBackEnd_ListNVMfRemoteControllers(t *testing.T) {
 				}
 				// Empty NextPageToken indicates end of results list
 				if tt.size != 1 && response.NextPageToken != "" {
-					t.Error("response: expected", tt, "received", response)
+					t.Error("Expected end of results, receieved non-empty next page token", response.NextPageToken)
 				}
 			}
 

diff --git a/pkg/frontend/blk_test.go b/pkg/frontend/blk_test.go
@@ -292,7 +292,7 @@ func TestFrontEnd_ListVirtioBlks(t *testing.T) {
 				}
 				// Empty NextPageToken indicates end of results list
 				if tt.size != 1 && response.NextPageToken != "" {
-					t.Error("response: expected", tt, "received", response)
+					t.Error("Expected end of results, receieved non-empty next page token", response.NextPageToken)
 				}
 			}
 

diff --git a/pkg/frontend/nvme_test.go b/pkg/frontend/nvme_test.go
@@ -378,7 +378,7 @@ func TestFrontEnd_ListNVMeSubsystem(t *testing.T) {
 				}
 				// Empty NextPageToken indicates end of results list
 				if tt.size != 1 && response.NextPageToken != "" {
-					t.Error("response: expected", tt, "received", response)
+					t.Error("Expected end of results, receieved non-empty next page token", response.NextPageToken)
 				}
 			}
 
@@ -1365,7 +1365,7 @@ func TestFrontEnd_ListNVMeNamespaces(t *testing.T) {
 				}
 				// Empty NextPageToken indicates end of results list
 				if tt.size != 1 && response.NextPageToken != "" {
-					t.Error("response: expected", tt, "received", response)
+					t.Error("Expected end of results, receieved non-empty next page token", response.NextPageToken)
 				}
 			}
 

diff --git a/pkg/middleend/middleend_test.go b/pkg/middleend/middleend_test.go
@@ -551,7 +551,7 @@ func TestMiddleEnd_ListEncryptedVolumes(t *testing.T) {
 				}
 				// Empty NextPageToken indicates end of results list
 				if tt.size != 1 && response.NextPageToken != "" {
-					t.Error("response: expected", tt, "received", response)
+					t.Error("Expected end of results, receieved non-empty next page token", response.NextPageToken)
 				}
 			}