Skip to content

Commit

Permalink
Remove no-op tooltip icon definition
Browse files Browse the repository at this point in the history
Button tooltip does not support icons, futher the linked code would fail with
a NoMethodError as `EmojiReactions.emoji` is not defined (note the plural definition)
which should be singular `EmojiReaction.emoji`

This was just forgotten, never gets executed.
  • Loading branch information
akabiru committed Jan 24, 2025
1 parent 306b24c commit 7353d83
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@
classes: "op-reactions-button"
)) do |button|
button.with_tooltip(text: number_of_user_reactions_text(data[:users]),
test_selector: "reaction-tooltip-#{reaction}") do
button.with_icon(EmojiReactions.emoji(reaction), size: :small)
test_selector: "reaction-tooltip-#{reaction}")
end
"#{EmojiReaction.emoji(reaction)} #{data[:count]}"
end
Expand Down

0 comments on commit 7353d83

Please sign in to comment.