-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 initial personas draft #1824
📖 initial personas draft #1824
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1824 +/- ##
=======================================
Coverage 68.44% 68.44%
=======================================
Files 63 63
Lines 5134 5134
=======================================
Hits 3514 3514
Misses 1390 1390
Partials 230 230
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just few nits.
Otherwise, it seems fine for me 👍
Great work
Signed-off-by: Jordan Keister <[email protected]>
Signed-off-by: Jordan Keister <[email protected]>
87deab0
to
753cf8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops. Missed the approval. Waiting to see if @michaelryanpeter wants to nibble on this as opposed to a later revision. |
Description
Adds initial 'personas' distilled from the somehow-unshareable miro board. This arises from review of #1796 and discussion in community and maintainer meetings, replacing it, adding background and role detail.
To-do (this or follow-ups)
Reviewer Checklist