Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Client go version metrics endpoint test #1821

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
+361 −270
Open

🐛 Client go version metrics endpoint test #1821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b34f3bf
Adds TEST_FILTER env var to e2e run
bentito Feb 27, 2025
363bf1d
Rewrite metrics endpoint test to use client-go
bentito Feb 27, 2025
ab09759
Rm pointer helpers, use k8s ones.
bentito Mar 3, 2025
c6c9b21
Rename main test client to globalClient (de-shadow "c")
bentito Mar 3, 2025
37a5453
Use apierrors, move deferred cleanup, less nesting
bentito Mar 3, 2025
1631058
Rename main test cfg->globalConfig de-shadow "cfg"
bentito Mar 3, 2025
cf22480
Allow test-unit filter on package and test
bentito Mar 3, 2025
15a1c2a
Drop UNIT_TEST_DIRS for TEST_PKGS + TEST_FILTER
bentito Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ test: manifests generate fmt lint test-unit test-e2e #HELP Run all tests.

.PHONY: e2e
e2e: #EXHELP Run the e2e tests.
go test -count=1 -v ./test/e2e/...
go test -count=1 -v -run "$(if $(TEST_FILTER),$(TEST_FILTER),.)" ./test/e2e/...

E2E_REGISTRY_NAME := docker-registry
E2E_REGISTRY_NAMESPACE := operator-controller-e2e
Expand All @@ -195,7 +195,10 @@ test-ext-dev-e2e: $(OPERATOR_SDK) $(KUSTOMIZE) $(KIND) #HELP Run extension creat
go test -count=1 -v ./test/extension-developer-e2e/...

ENVTEST_VERSION := $(shell go list -m k8s.io/client-go | cut -d" " -f2 | sed 's/^v0\.\([[:digit:]]\{1,\}\)\.[[:digit:]]\{1,\}$$/1.\1.x/')
UNIT_TEST_DIRS := $(shell go list ./... | grep -v /test/)
# Define TEST_PKGS to be either user-specified or a default set of packages:
ifeq ($(origin TEST_PKGS), undefined)
TEST_PKGS := $(shell go list ./... | grep -v /test/)
endif
COVERAGE_UNIT_DIR := $(ROOT_DIR)/coverage/unit

.PHONY: envtest-k8s-bins #HELP Uses setup-envtest to download and install the binaries required to run ENVTEST-test based locally at the project/bin directory.
Expand All @@ -211,7 +214,8 @@ test-unit: $(SETUP_ENVTEST) envtest-k8s-bins #HELP Run the unit tests
-tags '$(GO_BUILD_TAGS)' \
-cover -coverprofile ${ROOT_DIR}/coverage/unit.out \
-count=1 -race -short \
$(UNIT_TEST_DIRS) \
-run "$(if $(TEST_FILTER),$(TEST_FILTER),.)" \
$(TEST_PKGS) \
-test.gocoverdir=$(COVERAGE_UNIT_DIR)

.PHONY: image-registry
Expand Down
Loading
Loading