-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 [Bingo Upgrade] - Upgrade EnvTest and OPM tooling #1820
🌱 [Bingo Upgrade] - Upgrade EnvTest and OPM tooling #1820
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1820 +/- ##
==========================================
+ Coverage 68.43% 68.49% +0.05%
==========================================
Files 63 63
Lines 5132 5132
==========================================
+ Hits 3512 3515 +3
+ Misses 1390 1388 -2
+ Partials 230 229 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@camilamacedo86 lgtm and I'm leaving it up to you to merge. I just wonder if we want/need this before #1818 gets merged (or even if we want to make this part of that PR) |
Just updating the binary to the latest version! One thing is the version of the binary used for execution, like mocking data for E2E tests, and another is using it as a library. If we wanted to be super precise, we could say that dependencies should be updated together, but I think is fine to do this separately. Let me know if you see any issues! 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
for the changes in this PR. It's a little odd that bingo env can have binaries of a different version than what go pulls in, but it is what it is now.
Ideally it'd be nice to have what shows up in bingo + go mod be the same thing (which means any PR making changes in one would have to change the other)
Yep, that would not work because the dependabot will update the dependency but not the OPM bin. |
Description
Reviewer Checklist