-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Bump github.com/containers/image/v5 from 5.33.1 to 5.34.0 #1692
base: main
Are you sure you want to change the base?
🌱 Bump github.com/containers/image/v5 from 5.33.1 to 5.34.0 #1692
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
69c10b2
to
8656f73
Compare
/lgtm cancel Mistake. |
we need to make it pass in the tests
1f344a4
to
15052d3
Compare
@dependabot rebase |
fd6c6fe
to
f180d0a
Compare
f180d0a
to
38129de
Compare
This looks like an issue with The |
38129de
to
9709f3b
Compare
Right we already have https://github.com/operator-framework/operator-controller/blob/main/Makefile#L323 so trying to figureout how we can pass it so that it wont be an issue. |
9709f3b
to
1389508
Compare
1389508
to
23c02ad
Compare
@dependabot rebase |
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
@dependabot rebase |
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
@dependabot rebase |
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
@dependabot rebase |
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
|
||
.PHONY: lint-custom | ||
lint-custom: custom-linter-build #HELP Call custom linter for the project | ||
go vet -tags=$(GO_BUILD_TAGS) -vettool=./bin/custom-linter ./... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joelanford the problem seems to be that controller-gen does not accept that.
A newer version of github.com/containers/image/v5 exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Bumps [github.com/containers/image/v5](https://github.com/containers/image) from 5.33.1 to 5.34.0. - [Release notes](https://github.com/containers/image/releases) - [Commits](containers/image@v5.33.1...v5.34.0) --- updated-dependencies: - dependency-name: github.com/containers/image/v5 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Joe Lanford <[email protected]>
Signed-off-by: Joe Lanford <[email protected]>
d023b4c
to
d6d1734
Compare
Signed-off-by: Joe Lanford <[email protected]>
Signed-off-by: Joe Lanford <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1692 +/- ##
==========================================
- Coverage 68.50% 68.44% -0.06%
==========================================
Files 63 63
Lines 5134 5134
==========================================
- Hits 3517 3514 -3
- Misses 1388 1390 +2
- Partials 229 230 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Bumps github.com/containers/image/v5 from 5.33.1 to 5.34.0.
Release notes
Sourced from github.com/containers/image/v5's releases.
... (truncated)
Commits
51a5d96
Bump to c/image v5.34.0771660e
Bump c/storage to v1.57.17f0e59d
Merge pull request #2696 from Luap99/ENOENT3f17e2e
ignore ENOENT errors when parsing .crt filesc9771a8
ignore ENOENT errors when parsing registries.conf.d files1294122
ignore ENOENT errors when parsing registries.d filesb5c6aff
Merge pull request #2693 from containers/renovate/github.com-docker-docker-27.x1683fc2
Update module github.com/docker/docker to v27.5.1+incompatible16f7e1e
Merge pull request #2692 from containers/renovate/github.com-docker-cli-27.x30f0d87
Update module github.com/docker/cli to v27.5.1+incompatibleDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)