Fix login issue for LDAP users without email address #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ma-evans
force-pushed
the
blank-mail-fix
branch
from
756321c to
bdd6265
Compare
ma-evans
force-pushed
the
blank-mail-fix
branch
from
bdd6265 to
5ead1c0
Compare
doesn't return an e-mail address for the user.
ma-evans
force-pushed
the
blank-mail-fix
branch
from
5ead1c0 to
4e63200
Compare
|
Updated the issue description to better reflect the changes (issue was missing field in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where LDAP users without an email address wouldn't be populated in the dns-ui user list on login.
The user is able to log in but prompted with "something went wrong", which turned out to be caused by missing email field in
$ldapuser(e.g.$ldapuser['mail']). Checking the field exists resolves the error, and setting the email address to an empty string in this case seems as sensible as anything else.This was seen using Active Directory LDAP server, which in our case only returns the field for users with an email address assigned.