Candidate fix for issue 1440 wildcard dns not updating properly after modification or delete #1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… modification or delete
scareything
reviewed
Feb 1, 2024
| if hostErr == nil { | ||
| hostErr = self.resolver.RemoveHostname(host) | ||
| if hostErr == nil { | ||
| pfxlog.Logger().Debug("Removed Hostname from Resolver%v", host) |
There was a problem hiding this comment.
we should use the same log technique as other messages in this function. e.g.:
log.Debugf("Removed Hostname from Resolver %v", host)
same thing on line 623 below.
There was a problem hiding this comment.
ok thanks. changes pushed.
…g pattern in the StopIntercepting() method.
scareything
approved these changes
Feb 1, 2024
|
fixes #1440 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.