imply edge quickstart --already-initialized if --home #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qrkourier
commented
Dec 20, 2023
qrkourier
commented
Dec 20, 2023
dovholuknf
reviewed
Dec 20, 2023
dovholuknf
reviewed
Dec 20, 2023
dovholuknf
reviewed
Dec 20, 2023
dovholuknf
reviewed
Dec 20, 2023
dovholuknf
reviewed
Dec 20, 2023
dovholuknf
reviewed
Dec 20, 2023
dovholuknf
reviewed
Jan 8, 2024
ziti/cmd/edge/quickstart.go
Outdated
| @@ -65,7 +65,7 @@ func NewQuickStartCmd(out io.Writer, errOut io.Writer, context context.Context) | |||
| cmd := &cobra.Command{ | |||
| Use: "quickstart", | |||
| Short: "runs a Controller and Router in quickstart mode", | |||
| Long: `runs a Controller and Router in quickstart mode. By default, this will create a totally ephemeral network, only valid while running.`, | |||
| Long: "runs a Controller and Router in quickstart mode with a temporary Ziti home directory; suitable for testing and development", | |||
There was a problem hiding this comment.
is the changelog updated for this already? if not, probably worthwhile to update the changelog too
…me ZITI_HOME is set and ZITI_HOME/db exists on subsequent runs
qrkourier
force-pushed
the
quickstart-imply-init-if-home
branch
from
ebf5609 to
3b308df
Compare
dovholuknf
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…me ZITI_HOME is set and ZITI_HOME/db exists on subsequent runs