[pjrt] CreateViewOfDeviceBuffer now accepts a memory instead of a device #21649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_717628326
branch
5 times, most recently
from
3b8925c to
dc75e73
Compare
I took a shortcut in some PjRt implementations and recovered the device from a memory space, even though in general a memory space can be attached to multiple devices. PiperOrigin-RevId: 718892565
copybara-service
bot
force-pushed
the
test_717628326
branch
from
dc75e73 to
d71325f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[pjrt] CreateViewOfDeviceBuffer now accepts a memory instead of a device
I took a shortcut in some PjRt implementations and recovered the device from
a memory space, even though in general a memory space can be attached to
multiple devices.