Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTPS instead of SSH to get test dependencies #7

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

andy128k
Copy link
Contributor

No description provided.

@andy128k andy128k force-pushed the fix/PLAT-1371_fix_actions branch 15 times, most recently from 9254455 to f6a5bf2 Compare September 11, 2024 06:34
@andy128k andy128k force-pushed the fix/PLAT-1371_fix_actions branch from f6a5bf2 to 774e6db Compare September 11, 2024 06:43
@andy128k andy128k changed the title wip Use HTTPS instead of SSH to get test dependencies Sep 11, 2024
@andy128k andy128k marked this pull request as ready for review September 11, 2024 06:45
@andy128k andy128k requested a review from tmilak September 11, 2024 06:45
@tmilak
Copy link

tmilak commented Sep 11, 2024

Is this needed for running tests in devcontainers?

@andy128k
Copy link
Contributor Author

andy128k commented Sep 11, 2024

This comes from the need to run Github actions. But it is a generic issue. Customers of the public library must not be required to be GitHub users.

BTW, a regular (non-test) dependency on ranch is specified properly (as HTTPS).

@andy128k andy128k merged commit 1b5bdf5 into master Sep 11, 2024
2 checks passed
@andy128k andy128k deleted the fix/PLAT-1371_fix_actions branch September 11, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants