[feature] Added page to show OpenWISP versions #237 #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandafy
force-pushed
the
issues/273-openwisp-version
branch
from
1375385 to
4f3672c
Compare
pandafy
force-pushed
the
issues/273-openwisp-version
branch
from
4f3672c to
49ac68b
Compare
pandafy
force-pushed
the
issues/273-openwisp-version
branch
from
49ac68b to
5db88c1
Compare
nemesifier
requested changes
Nov 28, 2023
openwisp_utils/admin_theme/admin.py
Outdated
| @@ -38,6 +55,11 @@ def get_urls(self): | |||
| self.admin_view(autocomplete_view.as_view(admin_site=self)), | |||
| name='ow-auto-filter', | |||
| ), | |||
| path( | |||
| 'ow-info/', | |||
There was a problem hiding this comment.
Why not something more readable? Eg:
Suggested change
| 'ow-info/', | |
| 'openwisp-system-info/', |
| if package in EXTRA_OPENWISP_PACKAGES: | ||
| extra_packages[package] = version | ||
| continue | ||
| package_name = package.replace("-", "_") |
There was a problem hiding this comment.
why are you using double quotes here? We generally use single quotes around the codebase.
nemesifier
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #273
Changes
Screenshots
Checklist