Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Make sure to HTML escape all dashboard labels #361

Merged
merged 1 commit into from
Nov 23, 2023
Merged

[fix] Make sure to HTML escape all dashboard labels #361

merged 1 commit into from
Nov 23, 2023

Conversation

nemesifier
Copy link
Member

Changes

Make sure to HTML escape all dashboard labels.

Screenshots

Screenshot from 2023-11-22 18-16-52
Screenshot from 2023-11-22 18-16-39

Checklist

  • I have read the contributing guidelines.
  • I have manually tested the proposed changes.
  • I have written new test cases to avoid regressions. (if necessary)
  • I have updated the documentation. (e.g. README.rst)
  • I have added [change!] to commit title to indicate a backward incompatible change. (if required)
  • I have checked the links added / modified in the documentation.

@nemesifier nemesifier added the bug label Nov 23, 2023
@nemesifier nemesifier requested a review from pandafy November 23, 2023 15:37
@nemesifier nemesifier self-assigned this Nov 23, 2023
@coveralls
Copy link

Coverage Status

coverage: 98.175% (+0.008%) from 98.167%
when pulling 746b146 on fix-unescaped-dashboard-labels
into d3fce38 on master.

pandafy
pandafy approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@pandafy pandafy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have manually tested this fix. LGTM! 👍🏼

@nemesifier nemesifier merged commit 746b146 into master Nov 23, 2023
10 checks passed
@nemesifier nemesifier deleted the fix-unescaped-dashboard-labels branch November 23, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pandafy pandafy pandafy approved these changes

Assignees

@nemesifier nemesifier

Labels
bug
Projects
OpenWISP Priorities for next releases
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nemesifier @coveralls @pandafy