Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Admin actions require model permissions #386

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

pandafy
Copy link
Member

@pandafy pandafy commented Jun 20, 2024

@coveralls
Copy link

Coverage Status

coverage: 97.783%. remained the same
when pulling fc6e2a2 on fix-admin-actions
into 99d16ad on master.

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! See my comment below.

run: |
pip install -U ${{ matrix.django-version }}
# TODO: Remove before merging
pip install --force-reinstall --no-cache-dir --no-deps --upgrade https://github.com/openwisp/openwisp-utils/tarball/admin-action-perm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openwisp/openwisp-utils#379 is merged, please update this.

@pandafy pandafy force-pushed the fix-admin-actions branch 2 times, most recently from 202ec0c to 7108a35 Compare July 2, 2024 11:04
@coveralls
Copy link

Coverage Status

coverage: 97.784%. remained the same
when pulling 7108a35 on fix-admin-actions
into bd0cad9 on master.

@pandafy pandafy force-pushed the fix-admin-actions branch from 7108a35 to a935afd Compare July 2, 2024 11:09
@pandafy pandafy force-pushed the fix-admin-actions branch from a935afd to 56200e8 Compare July 2, 2024 11:10
@coveralls
Copy link

Coverage Status

coverage: 97.784%. remained the same
when pulling 56200e8 on fix-admin-actions
into bd0cad9 on master.

@coveralls
Copy link

Coverage Status

coverage: 97.784%. remained the same
when pulling 56200e8 on fix-admin-actions
into bd0cad9 on master.

@nemesifier nemesifier added the bug label Jul 2, 2024
@nemesifier nemesifier merged commit 98f49c4 into master Jul 2, 2024
20 checks passed
@nemesifier nemesifier deleted the fix-admin-actions branch July 2, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants