[fix] Fixed websocket connection use API URL and upgraded netjsongraph.js #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
pandafy
force-pushed
the
upgrade-netjsongraph.js
branch
2 times, most recently
from
1422251 to
6f2685f
Compare
The library will send credentials in fetch request which is required for CORS request.
pandafy
force-pushed
the
upgrade-netjsongraph.js
branch
from
6f2685f to
96b2c68
Compare
nemesifier
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
The netjspngraph.js library will send credentials in fetch request which is
required for CORS request.
Related to openwisp/docker-openwisp#353
Websocket should use the hostname defined in
OPENWISP_NETWORK_TOPOLOGY_API_BASEURL.Blockers