Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Consent mechanism for clean insights measurements #452 #458

Merged
merged 4 commits into from
Feb 24, 2024
Merged

[feature] Consent mechanism for clean insights measurements #452 #458

merged 4 commits into from
Feb 24, 2024

Conversation

pandafy
Copy link
Member

@pandafy pandafy commented Nov 30, 2023 •
edited
Loading

@pandafy pandafy marked this pull request as draft November 30, 2023 13:09
@pandafy pandafy marked this pull request as ready for review December 1, 2023 13:42
@pandafy pandafy force-pushed the issues/452-consent-mechanism branch from 23e2e95 to 7b409d1 Compare December 28, 2023 08:50
@pandafy pandafy changed the title [skip ci][feature] Consent mechanism for clean insights measurements #452 [feature] Consent mechanism for clean insights measurements #452 Dec 28, 2023
@pandafy pandafy force-pushed the issues/452-consent-mechanism branch from 7b409d1 to 2daedc3 Compare December 28, 2023 09:04
nemesifier
nemesifier requested changes Feb 16, 2024
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not mention clean insights in the code and comments.
Let's not assume people reading the code know what clean insights is, let's use a generic term like "Usage Metric Collection".

tasks/main.yml Outdated Show resolved Hide resolved
tasks/main.yml Outdated Show resolved Hide resolved
tasks/main.yml Outdated Show resolved Hide resolved
@pandafy pandafy force-pushed the issues/452-consent-mechanism branch from 2daedc3 to 66573af Compare February 19, 2024 16:05
@pandafy pandafy force-pushed the issues/452-consent-mechanism branch from 66573af to fb4baf8 Compare February 19, 2024 17:01
nemesifier
nemesifier requested changes Feb 20, 2024
View reviewed changes
tasks/consent.yml Outdated Show resolved Hide resolved
tasks/consent.yml Outdated

- name: Ensure user has enough time to read
pause:
seconds: 30
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's bring this down to 13 seconds

nemesifier
nemesifier reviewed Feb 22, 2024
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for openwisp/openwisp-utils#365 to be merged.

@nemesifier nemesifier merged commit b3991d3 into master Feb 24, 2024
4 checks passed
@nemesifier nemesifier deleted the issues/452-consent-mechanism branch February 24, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemesifier nemesifier nemesifier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] Consent mechanism for clean insisghts statistics
2 participants
@pandafy @nemesifier