feat: add default event to turn on the JavaScript GC.

openwebf · Mar 21, 2024 · fb0a8f6 · fb0a8f6
1 parent c6d843d
commit fb0a8f6
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 2 deletions.
diff --git a/bridge/core/dom/events/event_target.cc b/bridge/core/dom/events/event_target.cc
@@ -373,7 +373,7 @@ NativeValue EventTarget::HandleDispatchEventFromDart(int32_t argc, const NativeV
   assert(event->currentTarget() != nullptr);
 
   auto* window = DynamicTo<Window>(event->target());
-  if (window != nullptr && event->type() == event_type_names::kload) {
+  if (window != nullptr && (event->type() == event_type_names::kload || event->type() == event_type_names::kgcopen)) {
     window->OnLoadEventFired();
   }
 

diff --git a/bridge/core/events/event_type_names.json5 b/bridge/core/events/event_type_names.json5
@@ -223,6 +223,7 @@
     "webglcontextrestored",
     "wheel",
     "zoom",
-    "intersectionchange"
+    "intersectionchange",
+    "gcopen"
   ]
 }
diff --git a/webf/lib/src/dom/window.dart b/webf/lib/src/dom/window.dart
@@ -21,6 +21,7 @@ class Window extends EventTarget {
       : screen = Screen(context!.contextId, document.controller.ownerFlutterView, document.controller.view),
         super(context) {
     BindingBridge.listenEvent(this, 'load');
+    BindingBridge.listenEvent(this, 'gcopen');
   }
 
   @override

diff --git a/webf/lib/src/launcher/controller.dart b/webf/lib/src/launcher/controller.dart
@@ -325,6 +325,11 @@ class WebFViewController implements WidgetsBindingObserver {
     window = Window(BindingContext(view, _contextId, pointer), document);
     _registerPlatformBrightnessChange();
 
+    // 3 seconds should be enough for page loading, make sure the JavaScript GC was opened.
+    Timer(Duration(seconds: 3), () {
+      window.dispatchEvent(Event('gcopen'));
+    });
+
     // Blur input element when new input focused.
     window.addEventListener(EVENT_CLICK, (event) async {
       if (event.target is Element) {