fix: sliver layout child boundingClientRect offset error

openwebf · Dec 16, 2023 · 64cd037 · 64cd037
1 parent 074f2b2
commit 64cd037
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/webf/lib/src/dom/sliver_manager.dart b/webf/lib/src/dom/sliver_manager.dart
@@ -163,4 +163,20 @@ class RenderSliverRepaintProxy extends RenderProxyBox {
       }
     }
   }
+
+  void applyLayoutTransform(RenderObject child, Matrix4 transform, bool excludeScrollOffset) {
+    assert(child.parent == this);
+    assert(parentData is SliverMultiBoxAdaptorParentData);
+    assert(parent is WebFRenderSliverList);
+
+    SliverConstraints grandParentConstraints = (parent as WebFRenderSliverList).constraints;
+    Offset offset;
+    double? value = (parentData as SliverMultiBoxAdaptorParentData).layoutOffset;
+    if(grandParentConstraints.axisDirection == AxisDirection.right) {
+      offset = Offset(value ?? 0, 0);
+    } else {
+      offset = Offset(0, value ?? 0);
+    }
+    transform.translate(offset.dx, offset.dy);
+  }
 }
diff --git a/webf/lib/src/rendering/box_model.dart b/webf/lib/src/rendering/box_model.dart
@@ -52,6 +52,8 @@ Offset getLayoutTransformTo(RenderObject current, RenderObject ancestor, {bool e
     // Apply the layout transform for renderBoxModel and fallback to paint transform for other renderObject type.
     if (parentRenderer is RenderBoxModel) {
       offset += parentRenderer.obtainLayoutTransform(childRenderer, excludeScrollOffset);
+    } else if (parentRenderer is RenderSliverRepaintProxy) {
+      parentRenderer.applyLayoutTransform(childRenderer, transform, excludeScrollOffset);
     } else if (parentRenderer is RenderBox) {
       assert(childRenderer.parent == parentRenderer);
       if (childRenderer.parentData is BoxParentData) {