fix: optimize mimalloc dependency management #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andycall
reviewed
Dec 20, 2024
| @@ -1,4 +1,4 @@ | |||
| [submodule "vendor/mimalloc"] | |||
| path = vendor/mimalloc | |||
| url = https://github.com/microsoft/mimalloc | |||
| branch = v1.8.2 | |||
| branch = master | |||
There was a problem hiding this comment.
Yes, the master branch is the stable branch, master: latest stable release (based on dev-slice).
- Execute
git submodule update --remote --recursiveand push thevendor/mimallocfolder changes when a submodule needs to be updated. - Executing
git submodule update --init --recursivewill not update the master branch's latest commit, It will pull the commit from step 1.
There was a problem hiding this comment.
in addition, .gitmodules does not support tag or commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
mimalloc branch v1.8.2 was removed, causing the execution of
git submodule update --remoteto failSolution
git submodule update --remote --recursive.git submodule update --init --recursive, It will pull the commit from step 2.CI and Testing
david-clang:fix/gitmodulesbranch linkSubmodule path 'vendor/mimalloc': checked out '2765ec93026f445cad8f38e6b196dd226a1f6e61'It stands for testing with branch master(v2.1.7) .