Skip to content
/ mdn-bcd-collector Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silences warning logs and adds additional earlier skip check if no detected BCD updates #909

Merged
merged 8 commits into from
Dec 14, 2023
Merged

Silences warning logs and adds additional earlier skip check if no detected BCD updates #909

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bc8b26d
set log message default to quiet
ChrisC Nov 29, 2023
e4944b9
adds helper to detect contradictions
ChrisC Nov 29, 2023
ace7e41
adds check for "preview" statement
ChrisC Nov 29, 2023
846fb2e
catches specific version_added updates over generic support statements
ChrisC Dec 4, 2023
09eb95a
walks back edits to "normal" update unit test
ChrisC Dec 4, 2023
388dc62
stops using "contradictions" terminology
ChrisC Dec 7, 2023
1a15d19
fixes logic for handling "preview" statements
ChrisC Dec 7, 2023
f8a0f4a
Merge remote-tracking branch 'upstream/main' into only-log-warnings-o…
ChrisC Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
walks back edits to "normal" update unit test
  • Loading branch information
@ChrisC
ChrisC committed Dec 4, 2023
commit 09eb95aa75a7a3c4e9a33d5e9ffd7506da4e7b18
8 changes: 0 additions & 8 deletions scripts/update-bcd.test.ts
View file
Original file line number Diff line number Diff line change
@@ -286,11 +286,6 @@ const reports: Report[] = [
exposure: "Window",
result: false,
},
{
name: "api.unspecifiedVersionAPI",
exposure: "Window",
result: true,
},
{
name: "css.properties.font-family",
exposure: "Window",
@@ -1088,9 +1083,6 @@ describe("BCD updater", () => {
SuperNewInterface: {
__compat: {support: {chrome: {version_added: "100"}}},
},
unspecifiedVersionAPI: {
__compat: {support: {chrome: {version_added: "≤85"}}},
},
},
browsers: {
chrome: {name: "Chrome", releases: {82: {}, 83: {}, 84: {}, 85: {}}},
3 changes: 0 additions & 3 deletions unittest/bcd.test.ts
View file
Original file line number Diff line number Diff line change
@@ -116,9 +116,6 @@ export default {
SuperNewInterface: {
__compat: {support: {chrome: {version_added: "100"}}},
},
unspecifiedVersionAPI: {
__compat: {support: {chrome: {version_added: true}}},
},
},
browsers: {
chrome: {name: "Chrome", releases: {82: {}, 83: {}, 84: {}, 85: {}}},