Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cre8/issue239 #240

Merged
merged 4 commits into from
Jul 19, 2024
Merged

Cre8/issue239 #240

merged 4 commits into from
Jul 19, 2024

Conversation

cre8
Copy link
Contributor

@cre8 cre8 commented May 21, 2024

fixes #239

I am not sure if we can test it locally since we do not have a valid npm token to run the task successfully. Based on the logic:

  • lerna publishes to npm, creates the commits but does not push
  • we run the format command and commit the changes
  • Then we run execute the push to push the two commits.

cre8 added 2 commits May 21, 2024 12:58
@cre8
Format files after release
6fb9b47 
Fixes openwallet-foundation#239

Signed-off-by: Mirko Mollik <[email protected]>
@cre8
chore: format
664a07a 
Signed-off-by: Mirko Mollik <[email protected]>
@cre8 cre8 marked this pull request as draft May 21, 2024 11:21
@lukasjhan
Copy link
Member

Yeah.. we can't test it locally. Let's test it when we have next release :)

@cre8 cre8 marked this pull request as ready for review July 19, 2024 08:39
lukasjhan
lukasjhan approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@lukasjhan lukasjhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@cre8 cre8 merged commit 3883a74 into openwallet-foundation:main Jul 19, 2024
7 checks passed
@cre8 cre8 deleted the cre8/issue239 branch July 19, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berendsliedrecht berendsliedrecht berendsliedrecht approved these changes

@lukasjhan lukasjhan lukasjhan approved these changes

@zustkeeper zustkeeper Awaiting requested review from zustkeeper zustkeeper is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Format files after release
3 participants
@cre8 @lukasjhan @berendsliedrecht